feat: refresh token을 도입한다 #818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosow0212
approved these changes
Sep 30, 2023
| .httpOnly(true) | ||
| .build(); | ||
| } | ||
|
|
| @@ -77,9 +93,50 @@ public class AuthControllerTest extends MockBeanInjection { | |||
| ), | |||
| responseFields( | |||
| fieldWithPath("token").description("Access token") | |||
| ), | |||
| responseHeaders( //응답 헤더 문서화 | |||
| import org.springframework.web.servlet.config.annotation.WebMvcConfigurer; | ||
|
|
||
| import javax.servlet.Filter; | ||
|
|
||
| @Profile("!test") |
There was a problem hiding this comment.
이 부분이 잘 이해가 안가는데요 Profile을 이와 같이 설정한 이유가 무엇인가요??
be-student
reviewed
Oct 8, 2023
| return ResponseCookie.from(REFRESH_TOKEN, refreshToken) | ||
| .maxAge(Duration.ofMillis(expireLength)) | ||
| .path(VALID_COOKIE_PATH) | ||
| .sameSite("None") |
There was a problem hiding this comment.
어우 정말 오랜만이네요 반가워요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🕰️ Actual Time of Completion
🙋🏻 More
close #815