-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
경매 상세 페이지 수정(마감기한 시간 정보 뷰 수정 및 최고 입찰자 표시) #699
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fb29d8d
refactor: 높이 계산 로직 수정
rhthrhrl0 d52fa32
refactor: 마감 시간 스트링 생성 로직 수정
rhthrhrl0 1e2014e
feat: 최고입찰자인지 표시하는 기능 추가
rhthrhrl0 3174889
feat: 경매 상세 조회 api 응답 DTO 수정
rhthrhrl0 87f68af
feat: getRemainingHeight 로직 개선
rhthrhrl0 28d270a
refactor: 액션바 높이 상수화
rhthrhrl0 1815b86
refactor: 액션바 상수 수정
rhthrhrl0 5b45bab
refactor: 탭 레이아웃 너비 수정 및 액션바 로직 수정
rhthrhrl0 2393f9b
refactor: CoordinatorLayout을 사용하도록 수정
rhthrhrl0 a1a2cb4
refactor: 경매 상세 페이지 ui 가로모드 대응
rhthrhrl0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,8 @@ | |
|
||
<androidx.constraintlayout.widget.ConstraintLayout | ||
android:layout_width="match_parent" | ||
android:layout_height="match_parent"> | ||
android:layout_height="match_parent" | ||
android:layout_marginBottom="@dimen/height_submit_button"> | ||
|
||
<androidx.appcompat.widget.Toolbar | ||
android:id="@+id/tb_detail_auction" | ||
|
@@ -260,13 +261,16 @@ | |
<com.google.android.material.tabs.TabLayout | ||
android:id="@+id/tb_detail_info" | ||
android:layout_width="0dp" | ||
android:layout_height="wrap_content" | ||
android:layout_height="48dp" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 그걸 사용할까 하다가 안했던 이유는, 버튼이 아니라 탭 레이아웃에 대한 높이인데 이걸 적용하면, 나중에 리팩토링하다가 예기치 못하게 같이 바뀔 수 있을 것 같아요. |
||
android:layout_marginTop="24dp" | ||
android:backgroundTint="@color/grey_50" | ||
app:layout_constraintEnd_toEndOf="parent" | ||
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintTop_toBottomOf="@id/tv_auctioneer_count" | ||
app:tabIndicatorFullWidth="true" /> | ||
app:tabGravity="fill" | ||
app:tabIndicatorFullWidth="true" | ||
app:tabMaxWidth="0dp" | ||
app:tabMode="fixed" /> | ||
|
||
<androidx.viewpager2.widget.ViewPager2 | ||
android:id="@+id/vp_detail_info" | ||
|
@@ -282,7 +286,7 @@ | |
android:id="@+id/btn_auction_detail_bottom_button" | ||
style="@style/BigButton" | ||
android:layout_width="match_parent" | ||
android:layout_height="wrap_content" | ||
android:layout_height="@dimen/height_submit_button" | ||
android:layout_gravity="bottom" | ||
android:layout_marginHorizontal="@dimen/margin_side_layout" | ||
android:enabled="@{viewModel.auctionDetailBottomButtonStatus.enabled}" | ||
|
@@ -292,6 +296,7 @@ | |
android:padding="0dp" | ||
android:text="@{AuctionDetailFormatter.INSTANCE.getAuctionBottomButtonText(context,viewModel.auctionDetailBottomButtonStatus)}" | ||
android:textColor="@color/text_active_fixed" | ||
android:textSize="18dp" | ||
tools:text="입찰하기" /> | ||
</FrameLayout> | ||
</layout> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resources.configuration.screenHeightDp
를 사용하면 화면 orientation, cutout 사이즈를 고려하지 않아도 될 것 같아요!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
찾아주셔서 감사합니다! 테스트 중에 픽셀2 api33 버전에서 상태바가 같이 나오고 있는 것 같아서 확인이 필요할 것 같아요!