[자동차 경주] 이서현 미션 제출합니다. #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junjange
reviewed
Nov 4, 2023
| println(START_MESSAGE) | ||
| var CarNames: List<String> = getCarNames() | ||
| println(TRIAL_MESSAGE) | ||
| val trialCount: Int? = Console.readLine().toIntOrNull() |
There was a problem hiding this comment.
trialCount가 nulll일 때 처리를 해주는 게 좋을 거 같아요
There was a problem hiding this comment.
71번 줄에 따로 해둔다고 해놨었는데 생각해보니 null로 가지고 있는 것보다는 받은 걸 나중에 확인하는 게 훨씬 나을 수도 있겠네요!! 감사합니다!!😃
| fun startGame() { | ||
|
|
||
| println(START_MESSAGE) | ||
| var CarNames: List<String> = getCarNames() |
There was a problem hiding this comment.
대부분 변수마다 타입을 정의 하셨는데 코틀린은 타입 캐스팅이 되기 때문에 따로 안 적으셔도 됩니다!
그냥 보기 편하려고 의도하신거라면 그냥 지나가셔도 됩니다!
There was a problem hiding this comment.
어디에 쓰고 어디에 뺄지 모르겠어서 안쓰다가도 채우게 되더라구요ㅜㅜ
어느새 까먹고 있던 부분이었는데 기준을 세워봐야겠습니다 감사합니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.