[코드 리뷰용 PR] - 재구현 스터디 #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `contains` 에 잘못 들어가 있던 인자를 수정하여 이로 인한 버그를 픽스한다.
* 이전: `InputView` 에서 유효성 검증 후 `Command` 타입으로 변환한다. * 이후: 유효성 검증과 타입 변환을 `NumbersConverter` 에서 수행한다.
Tnalxmsk
reviewed
Dec 1, 2023
| } | ||
| return BaseballNumbers(numbers.toList()) | ||
| } | ||
| } |
There was a problem hiding this comment.
저도 Generator 인터페이스를 만들어 상속 받는 방식으로 구현할지 고민하다 object로 NumberGenerator를 구현했는데 어떤 과정을 거쳐 이렇게 구현하게 되셨는지 궁금합니다!
Tnalxmsk
reviewed
Dec 1, 2023
|
|
||
| class RandomAnswerGenerator : AnswerGenerator { | ||
| override fun generate(): BaseballNumbers { | ||
| val numbers = mutableSetOf<BaseballNumber>() |
There was a problem hiding this comment.
Set으로 depth를 줄이셨군요
저는 예시 코드를 수정할 생각을 안해서 depth를 줄일 고민을 하지 않았었는데 좋은 것 같습니다!
Tnalxmsk
reviewed
Dec 1, 2023
| } while (inputView.readCommand().toCommand() == Command.RESTART) | ||
| } | ||
|
|
||
| private fun oneCycleGame(answer: BaseballNumbers) { |
There was a problem hiding this comment.
코틀린 코딩 컨벤션에 함수, 메서드의 이름은 동사 또는 동사구로 짓는 것으로 설명하고 있는데 이 메서드 이름은 의도하신 걸까요?
https://kotlinlang.org/docs/coding-conventions.html#choose-good-names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.