[코드 리뷰용 PR입니다!] - 재구현 스터디 #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getupminaaa
reviewed
Nov 4, 2023
Comment on lines
+16
to
+19
| strike == 0 && ball == 0 -> "낫싱" | ||
| strike > 0 && ball == 0 -> "${strike}스트라이크" | ||
| strike == 0 && ball > 0 -> "${ball}볼" | ||
| else -> "${ball}볼 ${strike}스트라이크" |
There was a problem hiding this comment.
볼, 스트라이크, 낫싱 문자열로 Constants 클래스로 관리하면 좋을 것 같아요!
Comment on lines
+25
to
+27
| do { | ||
| oneCycleGame() | ||
| } while (baseBall.gameStatus()) |
There was a problem hiding this comment.
do-while문을 사용하니까 코드가 엄청 간경하네요,,, 저도 배워갑니다!!
| } | ||
|
|
||
| private fun makeIntList(number: String): List<Int> { | ||
| return number.map { it.digitToInt() }.toList() |
There was a problem hiding this comment.
map의 반환값이 List라 굳이 toList()를 할 필요는 없어 보입니다!
getupminaaa
reviewed
Nov 4, 2023
Comment on lines
+14
to
+16
| gameInit() | ||
| gameStart() | ||
| gameEnd() |
There was a problem hiding this comment.
게임을 세부분으로 나누어 구현하니까 가독성이 좋은 것 같아요! 배워갈게요!
| import baseball.util.Constants.RESTART | ||
| import java.lang.IllegalArgumentException | ||
|
|
||
| object Validator { |
There was a problem hiding this comment.
전체적으로 require() 문을 사용하는 것이 더 좋아보여요!
park-yina
reviewed
Nov 15, 2023
Comment on lines
+5
to
+14
| class BaseBall { | ||
| private var _strike = 0 | ||
| val strike: Int | ||
| get() = _strike | ||
|
|
||
| private var _ball = 0 | ||
| val ball: Int | ||
| get() = _ball | ||
|
|
||
|
|
There was a problem hiding this comment.
get()에 대해서는 활용법을 잘 몰랐는데 정말 적확한 곳에 사용하신 것 같아요. 잘 배워갑니다
Comment on lines
+3
to
+10
| object Constants { | ||
| const val RESTART = "1" | ||
| const val QUIT = "2" | ||
| const val GAME_NUMBER_LENGTH = 3 | ||
| const val START_INDEX = 1 | ||
| const val END_INDEX = 9 | ||
| const val REGEX = "[1-9]{3}" | ||
| } |
There was a problem hiding this comment.
저도 object를 사용하였는데, 클래스와 같은 곳에 배치하니 가독성이 떨어져서 고민이 많았습니다. 근데 다른 패키지로 빼서 표현할 수도 있다는 것은 아는게 적어서 전혀 생각도 못한 방법이었는데...와 정말 좋은 아이디어 인 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.