forked from woowacourse/java-chess
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[체스 - 3, 4단계] 아토(이혜린) 미션 제출합니다. #24
Open
hyxrxn
wants to merge
36
commits into
woowacourse-6th-code-review-study:hyxrxn
Choose a base branch
from
hyxrxn:step2
base: hyxrxn
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Mar 25, 2024
-
[체스 - 1, 2단계] 아토(이혜린) 미션 제출합니다. (woowacourse#706)
* docs: 기능 요구 사항 정리 * feat(King): 검정 팀 여부 확인 Co-authored-by: leegwichan <[email protected]> * docs: '팀 결정 여부 확인' 문서에 반영 Co-authored-by: leegwichan <[email protected]> * feat(Position): 각 위치 구분 - 가로 위치와 세로 위치 저장 - 가로 위치와 세로 위치가 같으면, 같은 객체로 판단 Co-authored-by: leegwichan <[email protected]> * feat(Board): 해당 위치의 말 확인 Co-authored-by: leegwichan <[email protected]> * feat(BoardFactory): 체스 말 위치 초기화 Co-authored-by: leegwichan <[email protected]> * refactor(domain): 패키지 분리 Co-authored-by: leegwichan <[email protected]> * feat(ChessGame): 초기 체스 보드 출력 - 대문자는 검정말, 소문자는 흰말로 출력 Co-authored-by: leegwichan <[email protected]> * refactor(OutputView): 메서드 분리 Co-authored-by: leegwichan <[email protected]> * refactor(ChessGame): 메서드 분리 Co-authored-by: leegwichan <[email protected]> * style(OutputView): 불필요한 공백 제거 Co-authored-by: leegwichan <[email protected]> * feat(InputView): 커멘드 입력 Co-authored-by: leegwichan <[email protected]> * feat(ChessGame): 종료 커멘드 반영 Co-authored-by: leegwichan <[email protected]> * style(Team): 개행 추가 Co-authored-by: leegwichan <[email protected]> * feat(Row): 남북 이동 Co-authored-by: leegwichan <[email protected]> * feat(Column): 동서 이동 Co-authored-by: leegwichan <[email protected]> * feat(Position): 다음 위치 확인 Co-authored-by: leegwichan <[email protected]> * refactor(Rank, File): 클래스명 변경 Co-authored-by: leegwichan <[email protected]> * feat(MovementRule): 연속적인 움직임 - 이동 가능 여부 판단 - 해당 경로 파악 Co-authored-by: leegwichan <[email protected]> * feat(KnightMovement): 나이트 움직임 - 이동 가능 여부 판단 - 해당 경로 파악 Co-authored-by: leegwichan <[email protected]> * feat(KingMovement): 킹 움직임 - 이동 가능 여부 판단 - 해당 경로 파악 Co-authored-by: leegwichan <[email protected]> * feat(Piece): 각 기물별 가능한 경로 파악 Co-authored-by: leegwichan <[email protected]> * feat(Board): 시작 위치의 말을 도착 위치로 이동 Co-authored-by: leegwichan <[email protected]> * feat(ChessGame): 이동 커멘드 반영 Co-authored-by: leegwichan <[email protected]> * feat(PawnDefaultMovement): 폰 기본 움직임 - 이동 가능 여부 판단 - 해당 경로 파악 Co-authored-by: leegwichan <[email protected]> * fix(Rook): 남쪽으로 이동할 수 있도록 수정 Co-authored-by: leegwichan <[email protected]> * feat(PawnFirstMovement): 폰 처음 움직임 - 이동 가능 여부 판단 - 해당 경로 파악 Co-authored-by: leegwichan <[email protected]> * style: 컨벤션에 맞추어 공백 추가 Co-authored-by: leegwichan <[email protected]> * style(KingTest): 불필요한 구문 제거 Co-authored-by: leegwichan <[email protected]> * feat(Pawn): 가능한 경로 파악 Co-authored-by: leegwichan <[email protected]> * refactor(Piece): stream을 이용하여 가독성 개선 Co-authored-by: leegwichan <[email protected]> * refactor(ContinuousMovementRule): 패키지 분리 Co-authored-by: leegwichan <[email protected]> * refactor(PieceTest): 팀 확인 테스트 이동 Co-authored-by: leegwichan <[email protected]> * style(Piece): 불필요한 구문 제거 Co-authored-by: leegwichan <[email protected]> * test(Piece): 가능한 경로 파악 Co-authored-by: leegwichan <[email protected]> * feat(Piece): 에러 메시지 추가 Co-authored-by: leegwichan <[email protected]> * test(Position): 파일과 랭크 차이 계산 Co-authored-by: leegwichan <[email protected]> * refactor(ChessGame): 메서드 분리 Co-authored-by: leegwichan <[email protected]> * feat(ChessApplication): 사용자에게 에러메시지 출력 후 종료 Co-authored-by: leegwichan <[email protected]> * feat(DiscreteMovementRule): 공통 로직 추상 클래스로 분리 Co-authored-by: leegwichan <[email protected]> * style(ContinuousMovementRule): 불필요한 개행 제거 Co-authored-by: leegwichan <[email protected]> * feat(DiscreteMovementRule): 에러 메시지 추가 Co-authored-by: leegwichan <[email protected]> * feat(PawnFirstMovement): 잘못된 파라미터 입력 시 에러 발생 Co-authored-by: leegwichan <[email protected]> * refactor: 가독성을 위해 상수 추출 Co-authored-by: leegwichan <[email protected]> * refactor(GameCommand): 불필요한 메서드 삭제 Co-authored-by: leegwichan <[email protected]> * feat(BoardFactory): 객체 생성을 막기 위해 생성자 추가 Co-authored-by: leegwichan <[email protected]> * refactor(NorthWestMovementTest): 불필요한 접근제어자 제거 Co-authored-by: leegwichan <[email protected]> * style: 불필요한 개행 삭제 Co-authored-by: leegwichan <[email protected]> * refactor: 디미터 규칙 준수 Co-authored-by: leegwichan <[email protected]> * style: 가독성을 위해 개행 추가 Co-authored-by: leegwichan <[email protected]> * refactor(Position): 불필요한 메서드 삭제 Co-authored-by: leegwichan <[email protected]> * docs: 개선 필요 사항 분리 Co-authored-by: leegwichan <[email protected]> * style(Position): 가독성을 위해 this 추가 Co-authored-by: leegwichan <[email protected]> * refactor(BoardFactory): 메서드명 변경 * refactor(PieceDto): 클래스로 변경 - 주 생성자를 private으로 변경 * feat(BoardDto): 체스 보드 출력을 위한 Dto 생성 - OutputView에서 null 사용 제거 - ChessGame의 역할 분리 * feat(Board): 팀 규칙 추가 - 흰 말부터 차례로 이동 - 같은 팀 말이 있는 위치로 이동 불가 * refactor(MovementRule): 상속되지 않을 클래스에 final 추가 * refactor(Position): 파라미터 변수명 변경 * docs: 기능 요구 사항 추가 * feat(MovementRule): 적 여부 파라미터에 추가 - 폰 이동 시 적 여부 판단해서 이동 가능 여부 반환 - 폰 대각선 이동 방법 추가 * feat(MovementRule): 도착 위치는 이동 경로에 포함되지 않도록 변경 - 이동 경로란 출발 위치에서 도착 위치까지 갈 때 거쳐가는 칸들 - 출발 위치에서 시작해 이동 경로를 지나 도착 위치에 도달 - 출발 위치에서 도착 위치 사이에 거쳐가는 칸이 없는 경우 빈 리스트 반환 * feat(ChessGame): 잘못된 입력 시 오류 메시지 출력 후 재입력 * style(ChessGame): 컨벤션에 맞춰 공백 추가 * refactor(File): 오타 수정 * refactor(Board): 메서드 간략화 --------- Co-authored-by: leegwichan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 977d9e4 - Browse repository at this point
Copy the full SHA 977d9e4View commit details
Commits on Mar 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c3bb337 - Browse repository at this point
Copy the full SHA c3bb337View commit details -
Configuration menu - View commit details
-
Copy full SHA for 643c556 - Browse repository at this point
Copy the full SHA 643c556View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a15ab0 - Browse repository at this point
Copy the full SHA 5a15ab0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 023804a - Browse repository at this point
Copy the full SHA 023804aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44a9ffc - Browse repository at this point
Copy the full SHA 44a9ffcView commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dff28c7 - Browse repository at this point
Copy the full SHA dff28c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9eabc7b - Browse repository at this point
Copy the full SHA 9eabc7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ba0d88 - Browse repository at this point
Copy the full SHA 2ba0d88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 255cbb5 - Browse repository at this point
Copy the full SHA 255cbb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05a3547 - Browse repository at this point
Copy the full SHA 05a3547View commit details
Commits on Mar 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 724c9ef - Browse repository at this point
Copy the full SHA 724c9efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 46f55fc - Browse repository at this point
Copy the full SHA 46f55fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69aca9d - Browse repository at this point
Copy the full SHA 69aca9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6edbedd - Browse repository at this point
Copy the full SHA 6edbeddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b14727 - Browse repository at this point
Copy the full SHA 0b14727View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9b36cb - Browse repository at this point
Copy the full SHA b9b36cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c198908 - Browse repository at this point
Copy the full SHA c198908View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6017958 - Browse repository at this point
Copy the full SHA 6017958View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53e2cd6 - Browse repository at this point
Copy the full SHA 53e2cd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b748637 - Browse repository at this point
Copy the full SHA b748637View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16a3341 - Browse repository at this point
Copy the full SHA 16a3341View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfeb489 - Browse repository at this point
Copy the full SHA dfeb489View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38e8cad - Browse repository at this point
Copy the full SHA 38e8cadView commit details
Commits on Apr 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e493812 - Browse repository at this point
Copy the full SHA e493812View commit details -
Configuration menu - View commit details
-
Copy full SHA for 499e57b - Browse repository at this point
Copy the full SHA 499e57bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43dbfde - Browse repository at this point
Copy the full SHA 43dbfdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69a4af0 - Browse repository at this point
Copy the full SHA 69a4af0View commit details -
Configuration menu - View commit details
-
Copy full SHA for da26f30 - Browse repository at this point
Copy the full SHA da26f30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2940490 - Browse repository at this point
Copy the full SHA 2940490View commit details -
Configuration menu - View commit details
-
Copy full SHA for 426d51d - Browse repository at this point
Copy the full SHA 426d51dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85ad50b - Browse repository at this point
Copy the full SHA 85ad50bView commit details
Commits on Apr 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f70c091 - Browse repository at this point
Copy the full SHA f70c091View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec85ee9 - Browse repository at this point
Copy the full SHA ec85ee9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed1a5ba - Browse repository at this point
Copy the full SHA ed1a5baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2944796 - Browse repository at this point
Copy the full SHA 2944796View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.