forked from woowacourse/java-chess
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1,2단계 - 체스] 켈리(양성욱) 미션 제출합니다. #15
Open
kelly6bf
wants to merge
54
commits into
woowacourse-6th-code-review-study:kelly6bf
Choose a base branch
from
kelly6bf:step1
base: kelly6bf
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[1,2단계 - 체스] 켈리(양성욱) 미션 제출합니다. #15
kelly6bf
wants to merge
54
commits into
woowacourse-6th-code-review-study:kelly6bf
from
kelly6bf:step1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
- 기존 클래스명을 더 명확하게 변경함. - 부족한 테스트 케이스를 추가함. - 메서드 파라미터를 더 명확한 타입으로 개선함. Co-authored-by: Hyunguk Ryu <[email protected]>
- direction enum들을 MovementDirection으로 추상화 함. - 테스트를 수정함. Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <[email protected]>
Co-authored-현by: Hyunguk Ryu <[email protected]>
Co-authore현d-by: Hyunguk Ryu <[email protected]>
Co-authore현d-by: Hyunguk Ryu <[email protected]>
Co-authored-현by: Hyunguk Ryu <[email protected]>
Co-authored-by: Hyu성nguk Ryu <[email protected]>
Co-authored-by: Hyunguk Ryu <가[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.