✨ add support strict boolean expression (#48)

resolved #45
woohm402 · Jul 22, 2024 · a9c8ece · a9c8ece
1 parent f04731c
commit a9c8ece
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/packages/base/__tests__/base.test.ts b/packages/base/__tests__/base.test.ts
@@ -16,6 +16,6 @@ describe('@woohm402/eslint-config-base', function () {
   it('wrong', async function () {
     const [result] = await eslint.lintFiles([`${__dirname}/wrong.ts`]);
 
-    expect(result.errorCount).toBe(5);
+    expect(result.errorCount).toBe(6);
   });
 });
diff --git a/packages/base/__tests__/wrong.ts b/packages/base/__tests__/wrong.ts
@@ -12,8 +12,11 @@ function b() {
 }
 
 const c: number = 1;
-const d = `aa ${c || null}`;
+const d = `aa ${c === 1 || null}`;
+
+const e: boolean | null = false;
+const f = e && 'asdf';
 
 // below is correct
-console.debug(a, d);
+console.debug(a, d, f);
 b();
diff --git a/packages/base/src/index.ts b/packages/base/src/index.ts
@@ -51,6 +51,20 @@ const baseRules: ConfigWithExtends = {
         allowNever: false,
       },
     ],
+    '@typescript-eslint/strict-boolean-expressions': [
+      'error',
+      {
+        allowString: false,
+        allowNumber: false,
+        allowNullableObject: false,
+        allowNullableBoolean: false,
+        allowNullableString: false,
+        allowNullableNumber: false,
+        allowNullableEnum: false,
+        allowAny: false,
+        allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing: false,
+      },
+    ],
   },
 };