Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Square sync works without issues when using cached API response #227

Draft
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Oct 3, 2024

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

This PR makes improvements to syncing Square products. It includes the following changes:

  • Fixed deserialization of cached API response data.
  • Fixed a potential issue related to an infinite loop during inventory pull.
  • Reduced the maximum object retrieval limit from 100 to 50 to better support sites with low-resource servers.

Steps to test the changes in this Pull Request:

  1. Set up a Square dashboard with a large number of products (around 1k-5k).
  2. Set up the Square extension and import products, ensuring that they are imported without any issues.
  3. Perform a manual sync with Woo as the SOR and Square as the SOR, and ensure it works as expected.

Changelog entry

Fix – Ensure Square sync works without issues when using cached API responses.

@iamdharmesh iamdharmesh changed the title [WIP] Square sync improvements Ensure Square sync works without issues when using cached API response Oct 18, 2024
@qasumitbagthariya
Copy link
Contributor

QA Update ✅


I have verified this PR in the enhancement/341 branch which has been fixed and is functioning as intended.

I tested the following on this branch:

  • Verify with around 1k-5k produce and import / Sync

Testing Environment

  • WordPress: 6.6.2
  • Theme: Twenty Twenty-Four 1.2
  • WooCommerce - 9.3.3
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS Ventura 13.3
  • Branch: fix/sync-deserialize

image

Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for code review (Woo)
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:

  • Yes
  • Not Required/Applicable for this PR

@qasumitbagthariya qasumitbagthariya requested review from a team and diegocurbelo and removed request for a team October 21, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants