Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force decimals with JPY always to be 0 #279

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Force decimals with JPY always to be 0 #279

merged 3 commits into from
Jul 25, 2024

Conversation

alexiglesias31
Copy link
Collaborator

@alexiglesias31 alexiglesias31 commented Dec 30, 2023 •
edited
Loading

All Submissions:

  • Does your code follow the Extendables standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

  1. Install a built of this PR and the Price Based on Country plugin (free version)
  2. Add Japan with JPY currency in the Price Based on Country plugin.
  3. A customer with shipping address on Japan should be able to complete the checkout.

Changelog entry

Fix - Checkout error with JPY currency and decimals set to non 0.

@alexiglesias31 alexiglesias31 self-assigned this Dec 30, 2023
@alexiglesias31 alexiglesias31 marked this pull request as draft December 30, 2023 21:59
@lauramelos lauramelos merged commit f14f023 into woocommerce:main Jul 25, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexiglesias31 alexiglesias31

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexiglesias31 @lauramelos