Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve mutlicurrency compatibility #276

Conversation

alexiglesias31
Copy link
Collaborator

@alexiglesias31 alexiglesias31 commented Oct 11, 2023

All Submissions:

  • Does your code follow the Extendables standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

No specific related issues, but PR aims to allow 3rd party developers to add externally to this plugin compatibility with more multicurrency plugins.

How to test the changes in this Pull Request:

  1. Install a 3rd party multicurrency plugin not supported internally by the plugin
  2. Add compatibility creating another plugin (Guide will be provided)
  3. Amazon Pay plugin should detect the compatible instance.

Other information:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changelog entry

Add - Extendable Multicurrency compatibility

Copy link
Contributor

@kalessil kalessil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexiglesias31 alexiglesias31 merged commit e5b66c4 into woocommerce:main Oct 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants