Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/review prompt #267

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Conversation

dpanta94
Copy link
Member

All Submissions:

  • Does your code follow the Extendables standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

In the plugin's setting page a review prompt is being added. The prompt has 3 links.

  1. To the review page
  2. To dismiss the prompt
  3. To the support page

When this feature is released, the plugin will store 2 dates in the DB on the first admin request. The date of the installation/activation/update of the plugin including this feature (anniversary date). The date of the anniversary date + 1 month in the future (hidden_until_date).

When the actual date becomes > than the hidden until date, the review prompt will appear in the plugin's settings page.
When the user clicks the dismiss link of the prompt, the prompt will remain hidden until the next anniversary date arrives.

Option keys:
amazon_payments_advanced_anniversary_date
amazon_payments_advanced_hidden_until_date

How to test the changes in this Pull Request:

  1. The review prompt appears 1 month after installing a version including this feature. You can change the stored options in order to not have to wait.
  2. The links 1) and 3) open on a new tab and point to the expected URLs.
  3. Clicking the dismiss button will update the hidden_until_date option correctly and will hide the prompt until then.

Other information:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changelog entry

Add - Review Prompt

@dpanta94 dpanta94 requested a review from a team July 19, 2023 08:56
@dpanta94 dpanta94 self-assigned this Jul 19, 2023
Copy link
Contributor

@kalessil kalessil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please check my comment.

includes/admin/class-wc-amazon-payments-advanced-admin.php Outdated Show resolved Hide resolved
@dpanta94 dpanta94 merged commit 220fa85 into woocommerce:main Jul 19, 2023
4 checks passed
@dpanta94 dpanta94 deleted the feature/review-prompt branch July 19, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants