This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Gallery: Fix limited images displayed in the dialog #11716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
type: bug
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +21 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
roykho
force-pushed
the
product-gallery/fix/dialog-thumbnails
branch
from
a848a97 to
9766c0a
Compare
roykho
force-pushed
the
product-gallery/fix/dialog-thumbnails
branch
from
84b59f2 to
1f0918e
Compare
danieldudzic
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Very good work, @roykho 🙏 . This PR indeed allows for all thumbnails to be navigated with the Next/Previous button.
One super minor issue I have noticed, is that when navigating through thumbnails in the Dialog, this also updates the Large Image in the regular gallery, so you can end up in a situation where it's displaying an image without a thumbnail in the regular gallery. But I don't think this is such a big issue.
The Pager block needs also fixing in the Dialog - I'll open a separate issue for it.
Yes and there is an issue with the e2e test to ensure they're the same. However in my opinion I don't think they need to be the same. In fact I would call a
I think in the design, we actually want to remove this pager feature in the dialog only. As it is not there in the design so perhaps in your issue, we can suggest to remove it? |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11291
The available thumbnails in the dialog were not able to be navigated.
Why
So users can see all the available thumbnails in the dialog.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog