This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
Add storybook entry for Label component #11682
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
opr
and removed request for
a team
November 8, 2023 11:50
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
packages/checkout/components/text-input/text-input.tsx
|
alexflorisca
added
category: extensibility
Work involving adding or updating extensibility. Useful to combine with other scopes impacted.
focus: components
Work that introduces new or updates existing components.
type: storybook
Issues related to storybook.
skip-changelog
PRs that you don't want to appear in the changelog.
labels
Nov 8, 2023
Size Change: 0 B Total Size: 1.54 MB ℹ️ View Unchanged
|
opr
suggested changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should pass the args to the component like so:
const Template: StoryFn = ( args ) => <Label { ...args } />;
and add some sensible defaults.
Cool, thanks for pointing that out. I've made the changes, mind giving it another look? |
opr
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loads better! Cheers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
category: extensibility
Work involving adding or updating extensibility. Useful to combine with other scopes impacted.
focus: components
Work that introduces new or updates existing components.
skip-changelog
PRs that you don't want to appear in the changelog.
type: storybook
Issues related to storybook.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a storybook entry for the Label component
Why
To illustrate the component's use and provide some level of documentation.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).