This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Rename Checkbox List story to work with storybook 7 #11679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
focus: components
woocommercebot
requested review from
a team and
senadir
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.59 MB ℹ️ View Unchanged
|
senadir
force-pushed
the
add/checkbox-list-storybook
branch
from
ee142ab to
bff7a7c
Compare
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
opr
force-pushed
the
add/checkbox-list-storybook
branch
from
bff7a7c to
cfa2f45
Compare
senadir
approved these changes
Nov 17, 2023
senadir
force-pushed
the
add/checkbox-list-storybook
branch
from
cfa2f45 to
c04ae48
Compare
github-actions
bot
added
status: ready to merge
and removed
status: needs review
status: stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Renames Checkbox List story to work with storybook 7
Why
Previous PR #11469 was merged but does not work with storybook 7.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
npm run storybookExternal Components -> Checkbox Listand ensure it works.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog