This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Gallery: Add keyboard access #11373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
type: enhancement
roykho
added
the
skip-changelog
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +246 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
tarunvijwani
approved these changes
Oct 19, 2023
| } | ||
| }; | ||
|
|
||
| document.addEventListener( 'keydown', handleKeyEvents ); |
There was a problem hiding this comment.
Should we remove this event listener when the gallery is not open?
There was a problem hiding this comment.
Yes we probably should but I haven't found an elegant way to do that in this context. Any suggestions?
There was a problem hiding this comment.
For some reasons it is only showing 3 images in the gallery for me. Is this expected?
Yes that's expected and being worked on else where.
There was a problem hiding this comment.
Yes we probably should but I haven't found an elegant way to do that in this context. Any suggestions?
I'm also not sure, maybe somewhere we're handling the click. I'll take a deep dive into it and get back to you.
thealexandrelara
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Great work in here @roykho. Allowing shoppers to navigate between images using keyboard keys definitely improves the user experience. I've left some suggestions in the code, but I'm pre-approving this PR, since it's not a blocker 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11284
Adds keyboard access (ESC, LEFT ARROW, RIGHT ARROW) to the Product Gallery overylay/dialog/lightbox.
Why
By adding keyboard access to the Product Gallery overlay/dialog/lightbox, it makes it more accessible and better UX.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog