This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Gallery: Fix justification not saving correctly #11324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
skip-changelog
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +58 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
danieldudzic
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Hi @roykho,
Thanks for working on this!
The fix works well and allows for the justification setting to persist.
Would you mind sharing the process of debugging this? I'd like to understand the bug better.
Regarding the Orientation setting on the Row - I believe that's just the standard UI for the Row/Stack blocks. I don't believe this can be removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11104
This was a tricky one as I went down a rabbit hole :)
NOTE: While playing around with this, I realize the Orientation setting for the first inner block Row is not useful at all because that setting is dictated by the position of the thumbnails. So even if you explicitly set it to say "Vertical", after you change the thumbnails position, the Orientation can change. If we agree, I can open a separate issue to remove that setting from users (if possible).
Why
This PR fixes the issue where when you use the first
core/grouprow/stack's justification settings, the settings does not persist after refreshing in the editor.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog