This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove isExperimental flag from product-query module which is not experimental #10531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmanijak
changed the title
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
github-actions
bot
removed
the
status: stale
kmanijak
added
skip-changelog
woocommercebot
requested review from
a team and
samueljseay
and removed request for
a team
samueljseay
approved these changes
Nov 24, 2023
@samueljseay, yea... I suspected |
kmanijak
deleted the
fix/remove-unnecessary-experimental-flag-products
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the leftover
isExperimentalfrom Products (Beta) block. Even though the flag was there, block was meant to be available to users.Another question is why the block is available EVEN though the flag was here. I haven't finished my initial investigation hence the PR was in draft for some time. I'm doing PRs cleanup and decided to put this PR into review.
Accessibility
prefers-reduced-motionOther Checks
[type]label or a[skip-changelog]label.Screenshots
Testing
Automated Tests
User Facing Testing
Prerequisites:
npm run build:deploy) - ignore if you test the full plugin via ZIP fileWooCommerce Visibility
Performance Impact
Changelog