-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag for non-simple product types project #12811
Open
AnirudhBhat
wants to merge
5
commits into
trunk
Choose a base branch
from
issue/12807-support-for-variable-products-feature-flag
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add feature flag for non-simple product types project #12811
AnirudhBhat
wants to merge
5
commits into
trunk
from
issue/12807-support-for-variable-products-feature-flag
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unit testing purpose
… for POS products
…r POS when the feature flag is disabled.
…d for POS when the feature flag is enabled.
AnirudhBhat
added
type: task
An internally driven task.
feature: point of sale
POS project
labels
Oct 23, 2024
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12811 +/- ##
=========================================
Coverage 40.86% 40.86%
Complexity 5765 5765
=========================================
Files 1237 1238 +1
Lines 69857 69864 +7
Branches 9707 9708 +1
=========================================
+ Hits 28545 28550 +5
- Misses 38677 38679 +2
Partials 2635 2635 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12807
Description
This PR adds a feature flag so that we could remove the "Simple" products filter for the products api and start showing all different product types for POS. This would help us in development of supporting Variable products for POS.
Testing information
Unit tests have been added to ensure this change doesn't break anything.
The tests that have been performed
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: