-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide Jetpack upsells when site is black-flagged #12788
Hide Jetpack upsells when site is black-flagged #12788
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12788 +/- ##
=========================================
Coverage 40.80% 40.80%
- Complexity 5750 5753 +3
=========================================
Files 1237 1237
Lines 69827 69833 +6
Branches 9698 9699 +1
=========================================
+ Hits 28493 28498 +5
+ Misses 38707 38706 -1
- Partials 2627 2629 +2 ☔ View full report in Codecov by Sentry. |
e667523
to
8a8d8fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @hichamboushaba, works well 👍🏼
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/dashboard/DashboardViewModel.kt
Show resolved
Hide resolved
…websites # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/AppPrefs.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/AppPrefsWrapper.kt
Closes: #12782
Depends on #12780
Description
This PR adds the following changes:
Steps to reproduce
Testing information
The tests that have been performed
^
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: