[WOO POS] UI tests for Simple products banner in Products screen #12428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry and will be fixed in future iterations to trigger POS event when clicked on POS settings instead of payments menu.
…ucts screen is visited
…ts info dialog when clicked on learn more button.
…lose icon is clicked.
… it in our UI tests
…est so that the UI tests won't take much time to run
AnirudhBhat
added
category: ui tests
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…products-banner # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/WooPosHomeProductInfoDialog.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/products/WooPosBanner.kt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12428 +/- ##
============================================
- Coverage 40.64% 40.64% -0.01%
Complexity 5602 5602
============================================
Files 1214 1214
Lines 68105 68106 +1
Branches 9358 9358
============================================
Hits 27683 27683
- Misses 37885 37886 +1
Partials 2537 2537 ☔ View full report in Codecov by Sentry. |
AnirudhBhat
commented
Sep 27, 2024
| @@ -321,7 +321,8 @@ class MoreMenuViewModel @Inject constructor( | |||
| mapOf(VALUE_MORE_MENU_PAYMENTS_BADGE_VISIBLE to isPaymentBadgeVisible().toString()) | |||
| ) | |||
| moreMenuNewFeatureHandler.markPaymentsIconAsClicked() | |||
| triggerEvent(MoreMenuEvent.ViewPayments) | |||
| // triggerEvent(MoreMenuEvent.ViewPayments) | |||
| triggerEvent(MoreMenuEvent.NavigateToWooPosEvent) | |||
There was a problem hiding this comment.
This change was made solely to run UI tests and needs to be reverted. The reason for the change is that the store used for UI testing doesn't pass IPP onboarding, which causes the POS setting to not appear in the settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12377
Description
This PR:
Testing information
Ensure the CI is happy - specifically, UI test pipeline is green.
The tests that have been performed
Images/gif
Screen.Recording.2024-08-21.at.6.22.44.PM.mov
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: