This repository has been archived by the owner on Jul 29, 2018. It is now read-only.
Created initial Sign In & Register pages, added more info to the header #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rimpey please review initial commit of both pages |
| <h1>Log In</h1> | ||
| <form id="sign-in" method="POST" action="" class="large-4 row"> | ||
| <label for="email">Email:</label> | ||
| <input type="email" name="email" placeholder="Username" required> |
There was a problem hiding this comment.
Can you change the placeholder to Email Address? Just to make it explicitly clear it's the email address the user should enter
There was a problem hiding this comment.
@tanyapowell I followed the wireframe exactly, I will check with Jeanette if that is OK as it is a visual change too.
There was a problem hiding this comment.
That's cool! I had a conversation with my dad at lunchtime about filling in an online form and made me realise how important it is to be ridiculously clear on what you are asking for
lili2311
pushed a commit
that referenced
this pull request
Feb 15, 2016
Created initial Sign In & Register pages, added more info to the header
|
Opened issue for the placeholder |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
Register
Sign in