Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mattermost-10.3/10.3.1-r1: cve remediation #39326

Closed

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jan 11, 2025

Copy link
Contributor Author

octo-sts bot commented Jan 11, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Based on the error output, I'll provide a specific analysis and solution:

• Detected Error: "Failed to running update. Error: bumping the main module is not allowed 'github.com/mattermost/mattermost/server/v8'"

• Error Category: Configuration/Build

• Failure Point: The go/bump step in the pipeline attempting to update dependencies

• Root Cause Analysis: The go/bump action is trying to modify the main module, which is not allowed. The current configuration is attempting to update the core module itself rather than just its dependencies.

• Suggested Fix: Modify the go/bump step to only update the dependencies without touching the main module. Update the YAML as follows:

  - uses: go/bump
    with:
      deps: golang.org/x/[email protected] golang.org/x/[email protected]
      replaces: github.com/mholt/archiver/v3=github.com/anchore/archiver/[email protected]
      modroot: ./server
      tidy: false

• Explanation: Remove the github.com/mattermost/mattermost/server/v8 from the deps list since it's the main module. The gobump tool is designed to update dependencies, not the main module itself.

• Additional Notes:

  • Keep the replaces directive as it's still valid for dependency replacement
  • The tidy: false setting is correctly maintained due to the referenced issue
  • This change maintains the security updates while following proper module update patterns

• References:

This fix should allow the build to proceed while maintaining the necessary dependency updates and replacements.

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Jan 11, 2025
@mamccorm
Copy link
Member

@mamccorm mamccorm closed this Jan 16, 2025
@mamccorm mamccorm deleted the cve-mattermost-10.3-fe9dc0a8943eaa4ffe0499ec98b794eb branch January 16, 2025 01:46
@mamccorm mamccorm self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant