20250120-lean-fips #8370
Merged
20250120-lean-fips #8370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
previously approved these changes
Jan 23, 2025
douzzer
force-pushed
the
20250120-lean-fips
branch
from
bbb0c8f to
7a55bc0
Compare
…lCast_fips(); wolfcrypt/src/aes.c: add missing parens in GHASH_ONE_BLOCK_SW() to mollify clang-tidy; wolfssl/wolfcrypt/fips_test.h: add FIPS_CAST_AES_ECB; wolfssl/wolfcrypt/settings.h: #ifdef WOLFSSL_LINUXKM, #undef HAVE_LIMITS_H.
…stency with OpenSSL; fix internal functions wolfSSL_read_internal() and ReceiveData() to likewise accept size_t sz; add negative sz checks where needed to other functions that call wolfSSL_read_internal() and ReceiveData(); add min_size_t() and max_size_t() to misc.c/misc.h.
douzzer
force-pushed
the
20250120-lean-fips
branch
from
7a55bc0 to
1b338ab
Compare
change Buffers.prevSent and .plainSz from int to word32; change SendData() sz arg from int sz to size_t sz; add asserts in SendData() and ReceiveData() to prevent sz > INT_MAX (assuring no overflow internally or in the returned int). wolfssl/ssl.h and src/ssl.c: change WOLFSSL_BUFFER_INFO.length from unsigned int to word32 (no functional change, just for consistency); add wolfSSL_write_internal(), refactor wolfSSL_write() to call it, and fix wolfSSL_write_ex() to take size_t sz, not int sz.
…ev(), long ago annotated with PRAGMA_GCC("GCC diagnostic ignored \"-Wmaybe-uninitialized\"").
wolfcrypt/src/misc.c: fix typo, max_size_t_() -> max_size_t().
dgarske
previously approved these changes
Jan 25, 2025
…CK_SIZE, not MD4_BLOCK_SIZE.
dgarske
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfssl/wolfcrypt/types.h: tweak for buildability in no-PK FIPS, relimits.h.fixes for
clang-tidycomplaints withNO_ERROR_STRINGS.configure.ac: tweaks for claritysee https://github.com/wolfSSL/fips/pull/320