Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the typo in aarch64 AES MPULL macro. #8346

Closed
wants to merge 1 commit into from

Conversation

fraggerfox
Copy link

Description

Currently the build fails in FreeBSD aarch64 with the following message

FreeBSD main-arm64-default-job-07 15.0-CURRENT FreeBSD 15.0-CURRENT 1500030 arm64

wolfcrypt/src/cpuid.c:262:28: error: use of undeclared identifier 'CPUID_AARCH64_FEAT_PMULL'
  262 |             if (features & CPUID_AARCH64_FEAT_PMULL)
      |                            ^
1 error generated.
--- wolfcrypt/src/src_libwolfssl_la-sp_int.lo ---
--- wolfcrypt/src/src_libwolfssl_la-cpuid.lo ---
*** [wolfcrypt/src/src_libwolfssl_la-cpuid.lo] Error code 1

make[2]: stopped making "all-am" in /wrkdirs/usr/ports/security/wolfssl/work/wolfssl-5.7.6

Full build log

The PR fixes the typo in the macro name.

Testing

Applied the patch and was able to rebuild successfully in aarch64.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@fraggerfox fraggerfox marked this pull request as ready for review January 9, 2025 15:01
@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@embhorn
Copy link
Member

embhorn commented Jan 9, 2025

Hello @fraggerfox

Thanks for bringing this to our attention. We only accept code changes from approved contributors and we do not typically accept one line changes. That said, I will request a review of this and we can fix it in another PR.

Could you tell us a bit about your project using wolfSSL?

Thanks,
@embhorn

@embhorn
Copy link
Member

embhorn commented Jan 9, 2025

@SparkiDev - Could you please review this issue and fix in another PR if appropriate?

@fraggerfox
Copy link
Author

Hello @fraggerfox

Thanks for bringing this to our attention. We only accept code changes from approved contributors and we do not typically accept one line changes. That said, I will request a review of this and we can fix it in another PR.

Could you tell us a bit about your project using wolfSSL?

Thanks, @embhorn

Thank you for the reply, I maintain the package for FreeBSD's packaging system called ports.

I shall close this PR then for now.

@fraggerfox fraggerfox closed this Jan 9, 2025
@fraggerfox fraggerfox deleted the fix-arm64-build branch January 9, 2025 15:47
@embhorn
Copy link
Member

embhorn commented Jan 9, 2025

Thanks for those details! I've created issue #8347 to track this going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants