Initial ASCON hash256 and AEAD128 support based on NIST SP 800-232 ipd #8307
+8,018
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julek-wolfssl
force-pushed
the
ascon
branch
2 times, most recently
from
bd2fa1e to
e8b9bc4
Compare
|
retest this please |
Implemented based on the NIST Initial Public Draft "NIST SP 800-232 ipd". Testing based on KAT's available at https://github.com/ascon/ascon-c. Added configuration for testing in github action.
dgarske
reviewed
Jan 2, 2025
| @@ -6044,6 +6044,17 @@ then | |||
| AM_CFLAGS="$AM_CFLAGS -DHAVE_XCHACHA" | |||
| fi | |||
|
|
|||
| # ASCON | |||
There was a problem hiding this comment.
Should it be part of experimental or all yet?
There was a problem hiding this comment.
Its a complete but limited implementation. Its fair to list it under experimental for now. Should I require WOLFSSL_EXPERIMENTAL_SETTINGS to enable ASCON for now?
There was a problem hiding this comment.
Yes let's put ASCON under experimental for now. Thank you
dgarske
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented based on the NIST Initial Public Draft "NIST SP 800-232 ipd". Testing based on KAT's available at https://github.com/ascon/ascon-c. Added configuration for testing in github action.