ARM32 SHA-3 ASM: fix ldrd/strd for ARMv6 #7697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDRD/STRD not available with ARMv6 and the alternative is two ldr/str operations. Pointer was 64-bits causing second ldr/str to be 8 bytes passed first and not 4 bytes. Fixed in asm to add 4 rather than index.
SparkiDev
force-pushed
the
arm32_ldrd_strd_fix
branch
from
a1feab6 to
45442db
Compare
JacobBarthelmeh
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LDRD/STRD not available with ARMv6 and the alternative is two ldr/str operations. Pointer was 64-bits causing second ldr/str to be 8 bytes passed first and not 4 bytes. Fixed in asm to add 4 rather than index.
Testing
./configure 'CC=arm-linux-gnueabi-gcc' '--host=armv6' '--disable-shared' 'LDFLAGS=--static' '--enable-armasm' '--enable-sha3'
./wolfcrypt/test/testwolfcrypt
Checklist