Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for v3.4.0 release #363

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Jul 30, 2024

  • Updated CMake to include new examples.
  • Fixed doxygen issue with wolfTPM2_GetKeyTemplate_EK -> curveID.
  • Fixed issue with possible create key timeout by always adding XTPM_WAIT for Linux.

…TPM2_GetKeyTemplate_EK` -> `curveID`. Fixed issue with possible create key timeout by always adding `XTPM_WAIT` for Linux.
@dgarske dgarske requested review from bandi13 and embhorn July 30, 2024 20:22
@dgarske dgarske self-assigned this Jul 30, 2024
Copy link
Contributor

@bandi13 bandi13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix

/var/lib/jenkins/workspace/wolfSSL/nightly-docs-job-v2/wolfTPM/wolftpm/docs/README.md:76: warning: unable to resolve reference to '/examples/README.md' for \ref command

on https://github.com/wolfSSL/wolfTPM/blob/master/docs/README.md?plain=1#L76.

@dgarske
Copy link
Contributor Author

dgarske commented Jul 30, 2024

Please also fix

/var/lib/jenkins/workspace/wolfSSL/nightly-docs-job-v2/wolfTPM/wolftpm/docs/README.md:76: warning: unable to resolve reference to '/examples/README.md' for \ref command

on https://github.com/wolfSSL/wolfTPM/blob/master/docs/README.md?plain=1#L76.

I've tried fixing that, but then it breaks the links in GitHub. Let me try a ../ relative path approach and see if that works

@bandi13 bandi13 merged commit 724ff37 into wolfSSL:master Jul 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants