Fix for C_GetAttributeValue incorrectly erroring with `CKR_ATTRIBUT…

…E_VALUE_INVALID` when data == NULL. The `C_GetAttributeValue` should set length if data field is NULL.
wolfSSL · Jan 9, 2024 · 9afc2d3 · 9afc2d3
1 parent c9ccc51
commit 9afc2d3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/crypto.c b/src/crypto.c
@@ -243,13 +243,13 @@ static CK_RV CheckAttributes(CK_ATTRIBUTE* pTemplate, CK_ULONG ulCount, int set)
             return CKR_ATTRIBUTE_TYPE_INVALID;
 
         if (attrType[j].type == ATTR_TYPE_ULONG) {
-            if (attr->pValue == NULL)
+            if (attr->pValue == NULL && set)
                 return CKR_ATTRIBUTE_VALUE_INVALID;
             if (attr->ulValueLen != sizeof(CK_ULONG))
                 return CKR_BUFFER_TOO_SMALL;
         }
         else if (attrType[j].type == ATTR_TYPE_BOOL) {
-            if (attr->pValue == NULL)
+            if (attr->pValue == NULL && set)
                 return CKR_ATTRIBUTE_VALUE_INVALID;
             if (attr->ulValueLen != sizeof(CK_BBOOL))
                 return CKR_BUFFER_TOO_SMALL;
@@ -259,7 +259,7 @@ static CK_RV CheckAttributes(CK_ATTRIBUTE* pTemplate, CK_ULONG ulCount, int set)
             }
         }
         else if (attrType[j].type == ATTR_TYPE_DATE) {
-            if (attr->pValue == NULL)
+            if (attr->pValue == NULL && set)
                 return CKR_ATTRIBUTE_VALUE_INVALID;
             if (attr->ulValueLen != sizeof(CK_DATE))
                 return CKR_BUFFER_TOO_SMALL;