Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Armored mode with IAR #540

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Jan 24, 2025

Add support for Armored mode with IAR. Currently only supports ECDSA and Cortex-M. ZD19190

@dgarske dgarske self-assigned this Jan 24, 2025
@dgarske dgarske requested a review from danielinux January 24, 2025 21:12
@dgarske dgarske assigned danielinux and unassigned dgarske Jan 24, 2025
@danielinux
Copy link
Member

What about the wolfBoot_panic() macro in include/loader.h? Is this overridden elsewhere? I was expecting it to be redefined for the IAR case.

Copy link
Member

@danielinux danielinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks equivalent to GCC. Please double check wolfBoot_panic() which does not seem to be taken into account here.

@danielinux danielinux assigned dgarske and unassigned danielinux Jan 28, 2025
@dgarske
Copy link
Contributor Author

dgarske commented Jan 31, 2025

Looks equivalent to GCC. Please double check wolfBoot_panic() which does not seem to be taken into account here.

@danielinux I've confirmed the armored version of wolfBoot_panic() for armored builds and works correctly in IAR. That code builds correctly in IAR with WOLFBOOT_ARMORED set and is being compiled in. This PR is good as-is.

@dgarske dgarske requested a review from danielinux January 31, 2025 20:44
@dgarske dgarske assigned danielinux and unassigned dgarske Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants