Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classNames #926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add classNames #926

wants to merge 1 commit into from

Conversation

luixo
Copy link

@luixo luixo commented Mar 2, 2024

@wojtekmaj

Hello,
Following the recently discussed theme support for the package, I decided to make a draft for what it could look like.
This one lets a complete restyle of the calendar in a variety of wide-spread solutions (specifically, tailwindcss and css-in-js that let user retrieve classnames).

First of all, let me know if you're not up for this change in any way.

In case you are, there are a few points to discuss:

  • specific property names for classNames
  • nested classNames - I did what felt like a good compromise, but it can be more more nested / less nested
  • should className get deprecated in case this PR gets merged?
  • should package styling move towards css variables?
  • should tileClassName be the only function to generate the className? can we make it par with the inner class name function generator (getTileClassName) and let there be multiple tile className generators?

If you approve the concept, I'll do testing and some examples.

@luixo
Copy link
Author

luixo commented Jun 26, 2024

@wojtekmaj
Can we proceed with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant