Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with incorrect .pyd file extension generation #776

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrDengDengDeng
Copy link

No description provided.

@wjakob
Copy link
Owner

wjakob commented Nov 5, 2024

Related to issue #773.

@wjakob
Copy link
Owner

wjakob commented Nov 5, 2024

I am hesitant to merge this PR because there seem to be some platform-specific differences that aren't handled by this change.

On my macOS machine, the SOABI tag is cpython-312-darwin. So with two dashes, rather than a dash and an underline.

@MrDengDengDeng
Copy link
Author

If so, you should use different rules in cmake for different platforms

@wjakob
Copy link
Owner

wjakob commented Nov 5, 2024

Let me add @henryiii, who wrote this line originally. I started to look into this and became quite confused.

On my macOS laptop, the suffix is .cpython-312-darwin.so. On Windows, it seems to be of the form .cp311-win_amd64.pyd. This page presents yet another naming scheme https://peps.python.org/pep-0425/ (but is outdated), and the current version seems in disagreement as well: https://packaging.python.org/en/latest/specifications/platform-compatibility-tags/#platform-compatibility-tags.

What are these version tags actually supposed to look like? What's the right combination of dashes and underscores to detect a compatible form and have the right mechanism for Scikit-build and PyPy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants