[WIP] add wallet creation date #942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the GUI to support the latest lianad config file with the user/password option for bitcoind RPC authentication. The settings have been updated to set either cookie file path or user and password. The installer still only supports the cookie file and has only been updated with the changes required to compile. When starting, the internal bitcoind now looks for the cookie file in the usual location rather than relying on the config file.
If using a self-managed node, this adds the option to authenticate with the RPC server using user and password.
1.63 is the latest version supported by Debian. It's also now almost a year and a half old (August 2023). We start getting way behind on our dependency updates, and sometimes even missing some security updates (nothing which affects us but still..). Asking to support a less than 2.5yo compiler shouldn't be that much to ask, but hey. 1.63 is now a better balance between support for upstream updates and support for a not recklessly new compiler.
Took care of keeping dirs pinned to avoid the dirs license shitshow. See dirs-dev/dirs-sys-rs@e169da7#r111303146 for more.
This gives us bundled SQLite 3.44.0. Notably this patches CVE-2022-35737 but it shouldn't affect us.
It now finally accepts an option as argument.
The most notable change is rust-bitcoin's change in the serialization of transaction with no input. It now accounts for the segwit marker even for those. The base tx weight in coin selection had to be adapted to handle this. See https://gnusha.org/bitcoin-rust/2024-01-04.log for details.
Bump clippy in CI to latest stable.
Minor formatting fix Text change to specify 'Bitcoin Core' during installation download
This function is now called many times from the GUI via `create_spend` and we expect this log message to be generated multiple times.
While signing in parallele, only new signatures should be appended without race condition.
The GUI uses the InsufficientFunds error to get the missing amount when the user is creating a new spend. It is not straightforward to extract this information in a general way from the RPC error. Instead, this missing amount will be included in the command response. These changes are based on suggestions from darosior and edouardparis.
close wizardsardine#934 Co-authored-by: jp1ac4 <[email protected]>
…e wildcard and multipath
This commit also fix handling of create_spend result while updating liana:master close wizardsardine#841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #805