Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI][Connect] Refresh cache more often while wallet height is 0 #1363

Open
jp1ac4 opened this issue Sep 26, 2024 · 1 comment
Open

[GUI][Connect] Refresh cache more often while wallet height is 0 #1363

jp1ac4 opened this issue Sep 26, 2024 · 1 comment
Assignees
@jp1ac4
Milestone
v8 Liana - Wallet...

Comments

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Sep 26, 2024

The cache is refreshed every 120 seconds when using Liana Connect as a backend compared to 10 seconds otherwise.

When first creating the wallet, we will indicate to the user in #1361 that the wallet is still syncing. For Liana Connect, the wallet may appear to be syncing even once this has completed due to the longer cache refresh period.

For Liana Connect backends, we could refresh the cache more often while the wallet is still performing its initial sync (i.e. its height is still 0) and then revert to the current frequency.
@jp1ac4 jp1ac4 self-assigned this Sep 26, 2024
@edouardparis
Copy link
Member

I agree this would be better UX 👍

@jp1ac4 jp1ac4 mentioned this issue Oct 8, 2024
Merged
edouardparis added a commit that referenced this issue Oct 18, 2024
@edouardparis
Merge #1370: [GUI] Indicate wallet is syncing after completing installer
67c9262 
6f4eb79 gui: refresh cache more often while height is 0 (Michael Mallan)
a511102 gui(home): indicate that wallet is syncing (Michael Mallan)
b452966 gui(home): track blockheight from cache (Michael Mallan)
1d1e735 ui: add loading spinner that types text (Michael Mallan)
3c46a73 ui: add carousel loading spinner (Michael Mallan)
e4c1ab1 ui: render amount with chosen colors (Michael Mallan)
013feb3 ui: refactor amount function (Michael Mallan)

Pull request description:

  This is to resolve #1361.

  The home page considers the wallet to be syncing if its height is 0. In this case, the balance will slowly blink and a "Syncing..." text will appear just below.

  The home page will check the wallet's height upon each cache refresh, and will reload the home page once the syncing has completed so that the updated balance is displayed without the user needing to do anything.

  Both the blinking balance and "Syncing..." text use a new `Carousel` widget that cycles through different child widgets at a specified rate.

  EDIT: I've added an extra commit to address #1363 as that is also related to the wallet height and cache refresh.

ACKs for top commit:
  edouardparis:
    ACK 6f4eb79

Tree-SHA512: 04214ccb1cf998ae6f7589f2c37335416a6d39b668269c4e07e30c8713e1a0e9e46257c60cea7b19ee6d6e35cbdccaf1122d25a66e6e7e905de51fce185f9180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jp1ac4 jp1ac4

Labels
None yet
Projects
Liana General
Status: In Review
Milestone
v8 Liana - Wallet syncing / scanning ...
Development

No branches or pull requests
2 participants
@edouardparis @jp1ac4