-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/rn76 oldarch #7967
base: master
Are you sure you want to change the base?
Feat/rn76 oldarch #7967
Conversation
Fixed ios pod file
I'm so happy, FINALLY! |
Lol thanks, I'll review this personally within days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well looks great but it definitely looks like this change is not backwards compatible. Let's consider the limitations together.
lib/android/app/src/main/java/com/reactnativenavigation/utils/ReactTypefaceUtils.java
Show resolved
Hide resolved
...main/java/com/reactnativenavigation/viewcontrollers/viewcontroller/LayoutDirectionApplier.kt
Show resolved
Hide resolved
...java/com/reactnativenavigation/viewcontrollers/bottomtabs/attacher/modes/AttachModeTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check (and fix?) for RN73
As preparation for new arch, the project was upgraded to support RN 76 without the new arch.
New arch is still in progress
#7941