created new props to fix timeline width #2490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Jul 23, 2024
| @@ -247,7 +252,7 @@ const Timeline = (props: TimelineProps) => { | |||
| // @ts-expect-error | |||
| ref={scrollView} | |||
| style={styles.current.container} | |||
| contentContainerStyle={[styles.current.contentStyle, {width: constants.screenWidth}]} | |||
| contentContainerStyle={[styles.current.contentStyle, {width: (availableWidth ?? constants.screenWidth)}]} | |||
There was a problem hiding this comment.
I would prefer not to have a prop just for the content container width but instead, allow overriding/merge to the 'contentContainerStyle'. Maybe by exposing 'scrollViewProps' prop where you can pass any ScrollView props and override some (!) of its props.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the timeline events and hour rows are taking the width of a screen, which makes the event box overflow
added a prop where you can pass your container width to contain everything within
Before:
After:
