-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use first user account on attached Android devices #4421
base: master
Are you sure you want to change the base?
Conversation
Just a quick note: the value of |
7cec13d
to
da6ba21
Compare
@ericswpark, I see what the idea is, but I need to make sure whether this is actually the ONLY place that needs this addition. For now, I suggest using I'll try to find a spare time to look at this more closely in a week or two, with some Android phone at my disposal. |
See issue wix/Detox#4396 for more info PR of this patch available at wix/Detox#4421 Remove this patch once the PR is merged or an alternative fix is applied!
@noomorph I know you want to take a closer look to see if there are additional places that need the patch, but can those be added in a separate PR/branch? I've been running with the patch for the last few weeks and it has been rock stable so far. |
da6ba21
to
6d877ea
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Fixes wix#4396 This hardcodes the user ID of 0 when fetching the package list on Android, otherwise it will fail on devices that have multiple users (devices with the work profile or Samsung Secure Folder (Knox) enabled).
6d877ea
to
70aaf77
Compare
Description
Fixes #4396
This hardcodes the user ID of 0 when fetching the package list on Android, otherwise it will fail on devices that have multiple users (devices with the work profile or Samsung Secure Folder (Knox) enabled).
In this pull request, I have hardcoded in a value of user ID 0 when listing packages using ADB.
This should work in the majority of cases -- however there might be some developers that want to test their app in a work profile. I really need Android tests to work right now, so I just hardcoded in the ID value, but maybe a future PR can make this a configurable option. I don't foresee a ton of use for this as there aren't any issues filed about it (other than mine).
None of the below are applicable.