Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dev dependencies in docker build #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tommytrg
Copy link
Member

@Tommytrg Tommytrg commented Mar 8, 2022

Remove dev dependencies after the build has finished

@guidiaz
Copy link
Contributor

guidiaz commented Mar 9, 2022

it doesn't seem to reduce docker image size, but still very nice to have anyway

Copy link
Contributor

@guidiaz guidiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, not that good, as it provokes the following error when launching /dist/src/bin/ethers module on portainer:

internal/modules/cjs/loader.js:905
�
  throw err;
  ^
Error: Cannot find module 'ethers'
Require stack:
- /data/dist/src/bin/ethers/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
    at Function.Module._load (internal/modules/cjs/loader.js:746:27)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at require (internal/modules/cjs/helpers.js:93:18)
    at Object.<anonymous> (/data/dist/src/bin/ethers/index.js:4:16)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/data/dist/src/bin/ethers/index.js' ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants