-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cloudflare-module-loader.ts #453
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0ade1ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks okay to me, however I'm not sure if it doesn't hide the real issue.. It should never try to cleanup files, which don't exist anymore.. I'm concerned that we hide something here, which we should investigate in more detail.
I see, I agree with that. There's something that's why the file is looking for a .js file while the function is intended for a |
Changes
After the build happens with the cloudflare adapter, one of my applications threw error as attached. But the preview ran fine using wrangler. I then noticed then it was failing to read from a file that did not exist in the
dist/_worker.js
directory. I think this happens because the Astro cleanup happened but it had the older resultant map.Testing
Docs