Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table widget improvements #1285

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Conversation

bennothommo
Copy link
Member

@bennothommo bennothommo commented Jan 13, 2025

  • Style read-only columns with slightly darker grey background to indicate read-only state
  • Prevent editors from being created for all column types if read-only (previously, only string columns would be rendered read-only by setting the readonly attribute, this is not ideal because it can be easily changed)
  • Allow tab and arrow navigation for read-only columns
  • Make readOnly option case-insensitive
  • Allowed searching option to show search box even if adding and deleting buttons are disabled
  • Fixed styling of toolbar if only the search box is shown (no background previously)
  • Fixed styling of pagination
  • Fixed broken search if client datasource is used

In progress

  • Add support for inspector column type for data tables - allowing support for complex values for individual table records (ie. an object).

- Style readonly columns with grey background to clearly indicate read-only state
- Prevent editors from being created for all column types if readonly (previously, only string columns would be rendered read-only)
- Allow tab and arrow navigation for readonly columns
@bennothommo bennothommo added the enhancement PRs that implement a new feature or substantial change label Jan 13, 2025
@bennothommo bennothommo added this to the 1.2.8 milestone Jan 13, 2025
@bennothommo
Copy link
Member Author

Before

Screenshot From 2025-01-13 12-42-54

After

Screenshot From 2025-01-13 12-42-37

@bennothommo bennothommo marked this pull request as draft January 13, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that implement a new feature or substantial change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant