-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add asset BundleManager & re-organize the asset helper classes #1164
Conversation
@jaxwilko you might consider putting the "groups" of packages in that same class and call it |
Thy will be done |
Co-authored-by: Ben Thomson <[email protected]>
…er into wip/asset-version-manager
Docs for new BundleManager features have been added here: wintercms/docs#203 |
This PR adds a new
BundleManager
class which is responsible for managing the different "asset bundles" available in Winter. Bundles will automatically be offered by thevite:create
&mix:create
scaffolding commands as option flags.This allows us to:
I've also cleaned up some of the install logic and added some user feedback similar to
create:plugin
when running{$compiler}:create
.In addition to the above, this PR removes the majority of the fixtures for Mix/Vite configs and now lets subscribers modify the base config on the fly.
Once the configs have been set, either via a config file, or from config calls in a plugin, the following can be ran in the CLI:
./artisan vite:create Acme.Plugin --jaxjs # Or ./artisan mix:create Acme.Plugin --jaxjs
Plugins can call these methods to register handlers to modify either stub or config generation, or do additional tasks when the
{$compiler}:create
command is ran.