Docs for Laravel style relations #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjauvin
reviewed
Feb 27, 2024
Co-authored-by: Marc Jauvin <[email protected]>
LukeTowers
reviewed
Mar 1, 2024
LukeTowers
reviewed
Jul 29, 2024
LukeTowers
requested changes
Jul 29, 2024
Co-authored-by: Luke Towers <[email protected]>
Co-authored-by: Luke Towers <[email protected]>
Co-authored-by: Luke Towers <[email protected]>
Co-authored-by: Luke Towers <[email protected]>
4 tasks
|
@bennothommo do you have any thoughts on the pending comments here? |
Co-authored-by: Luke Towers <[email protected]>
|
@bennothommo ping |
|
@LukeTowers I left a comment here for one of your threads: #176 (comment) |
|
@LukeTowers all comments should be resolved now. |
LukeTowers
reviewed
Oct 8, 2024
…cs into wip/laravel-style-relations
LukeTowers
pushed a commit
to wintercms/storm
that referenced
this pull request
Oct 9, 2024
This PR allows people to define Laravel-style relations using methods that return Relation objects. So instead of:
public $belongsTo = [
'user' => User::class,
];
You may use:
public function user(): BelongsTo
{
return $this->belongsTo(User::class);
}
The main reason for this is to reduce friction for porting Laravel code over to Winter, and as a preference point for people who may wish to use the more declarative style of defining relations.
Documented by wintercms/docs#176
LukeTowers
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: wintercms/storm#167