Growatt serial-no buffer overrun + manifest pymodbus #1210
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Solved issue where the serial number read count is to large for the actual registers in function async_read_serialnr. - Updated pymodbus to allign with home assistants 25.1 version (thanks @Luflosi for the comment on the PR) - Updated version so version could be released if needed.
Rounding issue when expected a year of 2 digits but receiving one of 4 digits in functions: - value_function_rtc - value_function_rtc_ymd
|
My comment can be seen here: 00a319c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async_read_serialnr.value_function_rtc_ymdandvalue_function_rtcto handle years with 4 digits as well