Unify property extractor function names #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While we are still bike-shedding the naming I want to call out we'll want to keep but deprecate the old names, not get rid of them entirely. |
|
Yeah, I realised that after I pushed those commits. I was a bit too enthusiastic to get the bike-shedding going I think. I'll add that to the to-do list above. |
grodin
force-pushed
the
grodin/unify-prop-extractors
branch
from
761c293 to
8c74fce
Compare
Merged
grodin
force-pushed
the
grodin/unify-prop-extractors
branch
from
3c12edf to
770d37d
Compare
|
Let me know if you want this squashed |
evant
reviewed
Apr 18, 2024
docs/assertk-coroutines/assertk.coroutines.assertions/contains-all.html
Outdated
Show resolved
Hide resolved
grodin
force-pushed
the
grodin/unify-prop-extractors
branch
from
a003cd2 to
5a89a79
Compare
evant
reviewed
Apr 18, 2024
grodin
force-pushed
the
grodin/unify-prop-extractors
branch
from
3af4e67 to
0291fa5
Compare
|
I'll let you squash it |
evant
approved these changes
Apr 18, 2024
added 11 commits
April 18, 2024 23:13
JakeWharton
reviewed
Apr 18, 2024
| * ``` | ||
| */ | ||
| suspend fun <T, P> Assert<T>.having(name: String, extract: suspend (T) -> P): Assert<P> = |
There was a problem hiding this comment.
If we make the other one inline, we can eliminate this psuedo-overload. Do we want that? Both APIs used in the implementation are public.
There was a problem hiding this comment.
Yeah doing that would be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #521
I'm opening this as a draft as the docs aren't updated yet and this is just supposed to be to get the bikeshedding going.
Known things to fix before merge:
update docs