-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Support for custom headers #5
Feat: Support for custom headers #5
Conversation
@retrodaredevil not sure if you are accepting PRs but I really want to use this plugin |
I do generally welcome PRs on my projects. I'll take a closer look later and will likely have you change a few things. Do keep in mind that docker-compose is deprecated in favor of just docker compose, which is built in. It might be a few days until I get the time to fully review this PR |
cool, no problem
sure, but it still uses the
no problem |
I'm used to following npm run dev
mage -v build:linux
npm run server to get up and running. Has that changed since the addition of this delve stuff? The new stuff looks useful for debugging but now I'm unsure of how to actually test these change. Additionally, I think to get the CI to pass you need to run an I plan to do a squash merge on these changes. I'm also curious what GraphQL server you are using that requires you to have an |
no
you have a few options:
Whenever you make any changes on your code it will automatically rebuild and restart the plugin inside the container (which means you will have to reconnect your delve session)
I don't know what they are using/doing, I'm just an end user
My bad, fixed |
@retrodaredevil friendly bump 😁 |
New job go brrr. Hoping to find some free time in the next few days. Just need to test this locally and give the changes another quick look. |
Looks like to get it to run now I had to do this (discovered this from microsoft/vscode-go#3098 (comment)):
That allowed the delve debugger thing to start which happens when the docker container starts up.
So, I'm actually curious what changes for native custom header support have been made that give native custom header support. I'm pretty sure that custom headers were allowed before the update, I just don't think they were secure like I want to eventually add. In other words, the only thing I notice this PR actually changing is the |
That's odd, I didn't have this issue, please revert what you did and try the latest commit
I believe this is the PR that made it possible
They were sent to the pluging but only as a map, you would have to implement the header injection yourself, now the SDK does it for you automaticaly
That is correct, you can |
Very well done! Thanks for the PR! I assume you'd like me to make a release sooner rather than later so you can use the up to date version in your Grafana instance? |
Thanks, yeah that would be awesome |
I looked more closely at this, and it looks like it was merged way before grafana-plugin-sdk-go/v0.217.0 was released. So, I'm not sure exactly what upgrading the SDK helped you with, but it probably needed to be done anyway |
het @retrodaredevil is it expected to take this long for this new version to be available on the Grafana Plugins system/page? |
My bad. I submitted a plugin update submission to Grafana just now. I don't know how long plugin updates take, but when I submitted the plugin initially, I got some feedback on changes to make, and then after I made the changes it took maybe about a week for it to get published. So for this small change, I would imagine it will only take about a week, but my upper estimate is two weeks. |
No problem, thanks again |
Update: I had to fix a link in the plugin.json (unrelated to this PR), so I just now fixed that and I expect the plugin update to be live Monday or Tuesday. (I assume the people reviewing the updates only work on weekdays, otherwise it would be sooner) |
hey @retrodaredevil just wanted to say that I've updated the plugin and it is working correctly, thanks! |
This PR does two things (each on its own commit):
Accept: application/json
header to every request, not sure if it is required on every case but I had to add it in order to work for meThe update process was just running
npx @grafana/create-plugin@latest update && go get -u && go mod tidy