[FIX] testing fixes for performance problems with pixels on Android 14+ #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et#719) Co-authored-by: Andy Carra <[email protected]>
… map layer from map icon (wiglenet#721) Co-authored-by: Andy Carra <[email protected]>
…g into priority_fixes
* fixing icon attributes, which were rendering strangely. * more updates. still some icons to fix. --------- Co-authored-by: Andy Carra <[email protected]>
…g into priority_fixes
rksh
commented
Jan 10, 2025
| @@ -302,7 +303,7 @@ | |||
| <service | |||
| android:name=".WigleService" | |||
| android:enabled="true" | |||
| android:foregroundServiceType="location" | |||
| android:foregroundServiceType="location|dataSync" | |||
There was a problem hiding this comment.
or-ing with dataSync as that expects file operations on the service thread
rksh
commented
Jan 10, 2025
| if (SDK_INT >= Build.VERSION_CODES.R) { | ||
| Logging.info("service startForeground version R+"); | ||
| startForeground(NOTIFICATION_ID, notification, ServiceInfo.FOREGROUND_SERVICE_TYPE_LOCATION | ServiceInfo.FOREGROUND_SERVICE_TYPE_DATA_SYNC); | ||
| } else { |
There was a problem hiding this comment.
R+ special case for startForeground
rksh
commented
Jan 10, 2025
| private static final int DB_PRIORITY = Process.THREAD_PRIORITY_BACKGROUND; | ||
| private static final int DB_PRIORITY = Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE ? | ||
| /*Process.THREAD_PRIORITY_BACKGROUND |*/ Process.THREAD_PRIORITY_DEFAULT : | ||
| Process.THREAD_PRIORITY_BACKGROUND; |
There was a problem hiding this comment.
attempting to boost DB priority to stop tail-dropping writes in background
rksh
commented
Jan 10, 2025
| private static final int MAX_QUEUE = 512; | ||
| private static final int MAX_DRAIN = 512; // seems to work fine slurping the whole darn thing | ||
| private static final int MAX_QUEUE = Build.VERSION_CODES.R >= Build.VERSION.SDK_INT ? 768 : 512; | ||
| private static final int MAX_DRAIN = MAX_QUEUE; // seems to work fine slurping the whole darn thing |
There was a problem hiding this comment.
increasing queue size to try and drop fewer nets in in background mode
uhtu
approved these changes
Jan 10, 2025
|
obviated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.