-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix textdomains for add-on maps #4743
Fix textdomains for add-on maps #4743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it fot the map descriptions and it works fine. Found an issue in the former official maps where I raised a PR.
However if possible the Folder names pointing to the maps have the same name as the addon and should therefore be localized as well if possible. (this would be similar to the My_Maps folder which is localized.
…-maps-textdomains
The folder structure is defined inside the add-on itself. But I can implement that a map add-on can specify a profile of localized folder names which will be used for localization. |
Okay now you should see localized directory names for the Formerly Official Maps at version 1.0.3 Edit: Needs testing under Windows to check I got the dirname magic correctly |
will test as soon as the localization is in the PO files |
The strings are on TX now. Let me know when you've translated them and I'll trigger another sync then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it and the Former Maps directory got translated correctly as it is the same sting already translated. So this is working now and should be good to go.
translation is done |
…01 (GH #6380 / CB #4743) Co-authored-by: Tóth András <[email protected]> Co-committed-by: Tóth András <[email protected]>
Re widelands/wl_addons_server#26