Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix textdomains for add-on maps #4743

Merged
merged 6 commits into from
Mar 6, 2021

Conversation

Noordfrees
Copy link
Member

@Noordfrees Noordfrees added bug Something isn't working internationalization Translation system, string fixes, RTL support addon Problems and requests related to add-ons labels Mar 5, 2021
@Noordfrees Noordfrees added this to the v1.0 milestone Mar 5, 2021
@Noordfrees Noordfrees self-assigned this Mar 5, 2021
Copy link
Contributor

@hessenfarmer hessenfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it fot the map descriptions and it works fine. Found an issue in the former official maps where I raised a PR.
However if possible the Folder names pointing to the maps have the same name as the addon and should therefore be localized as well if possible. (this would be similar to the My_Maps folder which is localized.

@Noordfrees
Copy link
Member Author

The folder structure is defined inside the add-on itself. But I can implement that a map add-on can specify a profile of localized folder names which will be used for localization.

@Noordfrees
Copy link
Member Author

Noordfrees commented Mar 6, 2021

Okay now you should see localized directory names for the Formerly Official Maps at version 1.0.3

Edit: Needs testing under Windows to check I got the dirname magic correctly

@hessenfarmer
Copy link
Contributor

will test as soon as the localization is in the PO files

@Noordfrees
Copy link
Member Author

The strings are on TX now. Let me know when you've translated them and I'll trigger another sync then.

Copy link
Contributor

@hessenfarmer hessenfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it and the Former Maps directory got translated correctly as it is the same sting already translated. So this is working now and should be good to go.

@hessenfarmer
Copy link
Contributor

translation is done

@hessenfarmer hessenfarmer merged commit f501eb7 into widelands:master Mar 6, 2021
@Noordfrees Noordfrees deleted the 26-addon-maps-textdomains branch March 6, 2021 20:19
bunnybot pushed a commit that referenced this pull request Feb 28, 2024
…01 (GH #6380 / CB #4743)

Co-authored-by: Tóth András <[email protected]>
Co-committed-by: Tóth András <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon Problems and requests related to add-ons bug Something isn't working internationalization Translation system, string fixes, RTL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants