Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore but not drop NOQUEUE events while aggregating #192

Closed
wants to merge 1 commit into from

Conversation

whyscream
Copy link
Owner

As discussed in #190

@ulab
Copy link
Contributor

ulab commented Feb 3, 2024

Does the first drop() still drop all other lines?

And by "all" I mean not only postfix ones with no queueid (errors, master, …), but also every other log event that is fed into Logstash?

@whyscream whyscream closed this Feb 4, 2024
@whyscream
Copy link
Owner Author

Yes it does. The example seems to be a rather specific implementation that only wants to store details about succesful deliveries. See my extensive notes in #190 (comment)

@whyscream whyscream deleted the 150-ignore-but-not-drop-noqueue-events branch February 4, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants