Opt-in to uploading profiles from why.log() #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-rogers
requested review from
naddeoa,
natiska,
andyndang,
FelipeAdachi,
murilommen and
jamie256
jamie256
previously approved these changes
Oct 1, 2024
jamie256
reviewed
Oct 1, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separates the notion of authentication mode (authenticated, anonymous, local) from whether or not
why.log()should automatically upload profiles.Changes
allow_localdefault toTrueupload_on_logconfiguration parameter orthogonal to session type (aka authentication mode)upload_on_login interactive sessionsWhyLabsWriter::write()will warn about possible redundant uploads if called in a session withupdate_on_logenabledCloses whlabs/whylogs#1570