Add support for capturing group in tag inclusion. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current implementation, every search opens/loads Whoosh index and initiates a new `Searcher` instance. This commit introduces a singleton to eliminate such behaviour, except when syncing attachments that requires the new index. The downside of this change is that after syncing, the Flask app needs to be restarted for the searcher to use the new index.
In the current implementation, every search opens/loads Whoosh index to retrieve last sync time. This commit caches the last sync time. The downside of this change is that after syncing, the Flask app needs to be restarted for the searcher to use the new index.
This reverts commit acfcb32.
When server has small memory and documents are too many, syncing may cause OOM. This change may reduce such possibility.
Caching papers for 24hrs and reloading searcher index every 12hrs in case the index has been updated.
Compute the facet html in Python instead of in Jinja template. When facets are nested and in hundreds/thousands, this change can reduce rendering speed by hundreds of milliseconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-worked PR. It allows the use of capturing group when using regular expression to determine item inclusion by tags.
If
tag_include_recontains a named capture groupkerko, the capture will be used.For example, in Zotero, a reference has tags of "-tag-Topic 1" and "-tag-Topic 2".
tag_include_reto "-tag-(?P<kerko>.*)".If
tag_include_redoes not include a capture group of name "kerko", or if it does not include any capture groups, then the full tags will be used if matched.tag_include_reto "-tag-(?P<anotherName>.*)", or "-tag-".This ensures that we can have some tags in Zotero for private use while some others specifically for creating facets.